linux-kernel - Re: [PATCH] perf report: delay sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1339459512.3796.235.camel@schen9-DESK>
Date:	Mon, 11 Jun 2012 17:05:12 -0700
From:	Tim Chen <tim.c.chen@...ux.intel.com>
To:	David Ahern <dsahern@...il.com>
Cc:	acme@...stprotocols.net, linux-kernel@...r.kernel.org,
	mingo@...nel.org, peterz@...radead.org, fweisbec@...il.com,
	paulus@...ba.org, tglx@...utronix.de
Subject: Re: [PATCH] perf report: delay sample_type checks in pipe mode

On Mon, 2012-06-11 at 13:49 -0600, David Ahern wrote:
> On 6/11/12 1:48 PM, David Ahern wrote:
> > The pipeline:
> >    perf record -a -g -o - sleep 5 |perf inject -v -b  | perf report  -g -i -
> >
> > generates the warning:
> >    Selected -g but no callchain data. Did you call 'perf record' without -g?
> >
> > The problem is that the header data is not written to the pipe, so the
> > sample_type has not been available when perf_report__setup_sample_type is
> > called. For pipe mode, record dumps the sample type as part of the
> > synthesized events stream -- perf_event__synthesize_attrs(). Handle this
> > be detecting pipe mode and not doing early sanity checks on sample_type.
> 
> Slightly different fix. Tim: can you re-test?
> 
> David
> 

Works for me.

Tim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/