linux-kernel - Re: [PATCH] scsi: allow persistent reservations without CAP_SYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20439.30634.460606.215696@quad.stoffel.home>
Date:	Tue, 12 Jun 2012 13:08:58 -0400
From:	"John Stoffel" <john@...ffel.org>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	linux-kernel@...r.kernel.org, axboe@...nel.dk,
	linux-scsi@...r.kernel.org, jbottomley@...allels.com
Subject: Re: [PATCH] scsi: allow persistent reservations without CAP_SYS_RAWIO


Paolo> Persistent reservations commands cannot be issued right now
Paolo> without giving CAP_SYS_RAWIO to the process who wishes to send
Paolo> them.  This is a bit heavy-handed, allow these two commands.

This seems like a bad idea, now anyone can just put in a SCSI
reservation on a system and then you have to hunt around trying to
figure it out.  

What's the motivation here?  What's the use case this solves?  

John



Paolo> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
Paolo> ---
Paolo>         Ok for 3.5 as well?

Paolo>  block/scsi_ioctl.c |    2 ++
Paolo>  1 files changed, 2 insertions(+), 0 deletions(-)

Paolo> diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
Paolo> index 260fa80..5d6c9c1 100644
Paolo> --- a/block/scsi_ioctl.c
Paolo> +++ b/block/scsi_ioctl.c
Paolo> @@ -137,6 +137,7 @@ static void blk_set_cmd_filter_defaults(struct blk_cmd_filter *filter)
Paolo>  	__set_bit(SERVICE_ACTION_IN, filter->read_ok);
Paolo>  	__set_bit(RECEIVE_DIAGNOSTIC, filter->read_ok);
Paolo>  	__set_bit(MAINTENANCE_IN, filter->read_ok);
Paolo> +	__set_bit(PERSISTENT_RESERVE_IN, filter->read_ok);
Paolo>  	__set_bit(GPCMD_READ_BUFFER_CAPACITY, filter->read_ok);
 
Paolo>  	/* Audio CD commands */
Paolo> @@ -178,6 +179,7 @@ static void blk_set_cmd_filter_defaults(struct blk_cmd_filter *filter)
Paolo>  	__set_bit(GPCMD_MODE_SELECT_10, filter->write_ok);
Paolo>  	__set_bit(MODE_SELECT, filter->write_ok);
Paolo>  	__set_bit(LOG_SELECT, filter->write_ok);
Paolo> +	__set_bit(PERSISTENT_RESERVE_OUT, filter->write_ok);
Paolo>  	__set_bit(GPCMD_BLANK, filter->write_ok);
Paolo>  	__set_bit(GPCMD_CLOSE_TRACK, filter->write_ok);
Paolo>  	__set_bit(GPCMD_FLUSH_CACHE, filter->write_ok);
Paolo> -- 
Paolo> 1.7.1

Paolo> --
Paolo> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Paolo> the body of a message to majordomo@...r.kernel.org
Paolo> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paolo> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/