linux-kernel - Re: [Bcache v14 16/16] bcache: Debug and tracing code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120612174528.GB11365@google.com>
Date:	Tue, 12 Jun 2012 10:45:28 -0700
From:	Kent Overstreet <koverstreet@...gle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	g@...gle.com, linux-bcache@...r.kernel.org,
	linux-kernel@...r.kernel.org, dm-devel@...hat.com,
	tejun@...gle.com, agk@...hat.com, dan.j.williams@...el.com
Subject: Re: [Bcache v14 16/16] bcache: Debug and tracing code

On Tue, Jun 12, 2012 at 10:35:43AM -0700, Joe Perches wrote:
> "(uint64_t *)k - i->d" is what type again?
> What is a %zu?
> 
> Isn't that a mismatch?

You're right - ssize_t and size_t. I think gcc just isn't checking
signedness at all, that %i should be a %u too. Good catch.

> 
> > > > +static int debug_seq_show(struct seq_file *f, void *data)
> > > > +{
> > > > +	static const char *tabs = "\t\t\t\t\t";
> > > 
> > > Seems a _very_ odd use.
> > 
> > It is a strange hack.
> > 
> > The idea is that we want to indent more as we recurse; we could build up
> > a new string of tabs each time we recurse that's got one more tab than
> > our parent's, but that'd be a pain in the ass and it'd use more stack
> > space (though that should be fine here), so instead it's just
> > decrementing the pointer to the tab string to produce a string with one
> > more tab.
> 
> It's a nice idea, but that's not what's happening
> as I believe you reference tabs only once as &tabs[4]

bch_btree_dump() prints out tabs, and passes tabs - 1 when it recurses.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/