linux-kernel - Re: [PATCH v2] lib/decompress_unxz.c: removing all memory helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FD780D2.603@zytor.com>
Date:	Tue, 12 Jun 2012 10:48:02 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Nicolas Pitre <nicolas.pitre@...aro.org>
CC:	Lasse Collin <lasse.collin@...aani.org>,
	T Makphaibulchoke <tmac@...com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
	linux390@...ibm.com, lethal@...ux-sh.org, tglx@...utronix.de,
	mingo@...hat.com, x86@...nel.org, kaloz@...nwrt.org,
	jj@...osbits.net, matt.fleming@...el.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH v2] lib/decompress_unxz.c: removing all memory helper
 functions

On 06/12/2012 10:44 AM, Nicolas Pitre wrote:
> On Tue, 12 Jun 2012, H. Peter Anvin wrote:
> 
>> On 06/12/2012 10:26 AM, Nicolas Pitre wrote:
>>>
>>> Instead of copying, maybe this would be much better to make the content 
>>> of lib/string.c usable in a pre-boot environment.
>>>
>>
>> Not sure about that... a lot of it is #ifndef __HAVE_ARCH_* and you
>> *really* want those optimizations on some arches.
> 
> Sure.  What about:
> 
> lib/boot/mem.c: lib/string.c
> 	sed 's/^#ifndef __HAVE_ARCH_/#ifndef __HAVE_PREBOOT_ARCH_/' < $< > $@
> 
> This is over simplified but you get the idea.  Maybe lib/string.c itself 
> should be split into several files to help with a finer grained 
> selection.
> 

The point is that I think we pretty much end up with a null usable set
in the end.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/