linux-kernel - Re: [PATCH 1/2] driver: add PPI support in tpm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Jun 2012 12:00:38 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Kent Yoder <shpedoikal@...il.com>
CC:	"Zhang, Xiaoyan" <xiaoyan.zhang@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tpmdd-devel@...ts.sourceforge.net" 
	<tpmdd-devel@...ts.sourceforge.net>,
	"debora@...ux.vnet.ibm.com" <debora@...ux.vnet.ibm.com>,
	"srajiv@...ux.vnet.ibm.com" <srajiv@...ux.vnet.ibm.com>,
	"m.selhorst@...rix.com" <m.selhorst@...rix.com>,
	"linux-security-module@...r.kernel.org" 
	<linux-security-module@...r.kernel.org>,
	"james.l.morris@...cle.com" <james.l.morris@...cle.com>,
	"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
	"Cihula, Joseph" <joseph.cihula@...el.com>,
	"Wei, Gang" <gang.wei@...el.com>
Subject: Re: [PATCH 1/2] driver: add PPI support in tpm driver

On 06/12/2012 11:57 AM, Kent Yoder wrote:
> 
>   This code looks clean - my only suggestion would be to add an #ifdef
> CONFIG_ACPI around it so it compiles out on ppc.
> 

Better yet, any way to separate it out in a separate source file?

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/