linux-kernel - Re: [PATCH 1/2] clk: cache parent clocks only for muxes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Jun 2012 12:04:49 -0700
From:	Mike Turquette <mturquette@...com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Rajendra Nayak <rnayak@...com>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] clk: cache parent clocks only for muxes

On 20120606-11:47, Russell King - ARM Linux wrote:
> On Wed, Jun 06, 2012 at 02:41:30PM +0530, Rajendra Nayak wrote:
> > caching parent clocks makes sense only when a clock has more
> > than one parent (mux clocks).
> > Avoid doing this for every other clock.
> > 
> > Signed-off-by: Rajendra Nayak <rnayak@...com>
> > ---
> >  drivers/clk/clk.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > index 687b00d..40568e9 100644
> > --- a/drivers/clk/clk.c
> > +++ b/drivers/clk/clk.c
> > @@ -1229,7 +1229,7 @@ int __clk_init(struct device *dev, struct clk *clk)
> >  	 * If clk->parents is not NULL we skip this entire block.  This allows
> >  	 * for clock drivers to statically initialize clk->parents.
> >  	 */
> > -	if (clk->num_parents && !clk->parents) {
> > +	if ((clk->num_parents > 1) && !clk->parents) {
> 
> You don't need the additional parens here.  Please learn the C precedence
> rules.  Additional unnecessary parens can make expressions much harder
> to read.

Rajendra,

I've taken this patch into clk-next for testing.  I've fixed up the
extra parens locally, so no need for a resend.

Regards,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/