[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1339528648.4531.15.camel@jlt3.sipsolutions.net>
Date: Tue, 12 Jun 2012 21:17:28 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Sasha Levin <levinsasha928@...il.com>
Cc: wey-yi.w.guy@...el.com, linville@...driver.com,
ilw@...ux.intel.com, linux-wireless@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iwlwifi: re-order module_init order to prevent NULL ptr
deref
On Tue, 2012-06-12 at 21:13 +0200, Sasha Levin wrote:
> We need to make sure iwl_drv_init is called before iwl_init, since otherwise
> iwl_init will NULL ptr deref when trying to add a new mode.
>
> Signed-off-by: Sasha Levin <levinsasha928@...il.com>
> ---
> drivers/net/wireless/iwlwifi/Makefile | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/Makefile b/drivers/net/wireless/iwlwifi/Makefile
> index 98c8f64..16e39a4 100644
> --- a/drivers/net/wireless/iwlwifi/Makefile
> +++ b/drivers/net/wireless/iwlwifi/Makefile
> @@ -1,5 +1,3 @@
> -obj-$(CONFIG_IWLDVM) += dvm/
> -
Thanks! I already have a patch like this in my tree, will send a pull
request soon:
http://git.kernel.org/?p=linux/kernel/git/iwlwifi/iwlwifi-next.git;a=commit;h=4b75b1e49568dd6a30a1dddc47408cc6fde55608
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists