linux-kernel - Re: [PATCH v4] watchdog: Quiet down the boot messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120613075852.GB18819@gmail.com>
Date:	Wed, 13 Jun 2012 09:58:52 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Don Zickus <dzickus@...hat.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, nzimmer@....com,
	joe@...ches.com, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v4] watchdog: Quiet down the boot messages


* Don Zickus <dzickus@...hat.com> wrote:

> After the change, it is simplified to:

>     NMI watchdog enabled, takes one hw-pmu counter.

minor nit, the above line in the changelog does not match the 
code anymore.

> +	static unsigned long cpu0_err;

Please don't use statics inside functions - move it to file 
scope, before the function or so.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/