linux-kernel - Re: [PATCH 02/13] code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120613010209.GB6765@kroah.com>
Date:	Tue, 12 Jun 2012 18:02:09 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	stefani@...bold.net
Cc:	linux-kernel@...r.kernel.org, oneukum@...e.de,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 02/13] code cleanup

On Thu, Jun 07, 2012 at 10:20:32AM +0200, stefani@...bold.net wrote:
> From: Stefani Seibold <stefani@...bold.net>
> 
> - consistent nameing
> - more compact style
> - remove unneeded code
> 
> Signed-off-by: Stefani Seibold <stefani@...bold.net>
> ---
>  drivers/usb/usb-skeleton.c |  119 +++++++++++++++++---------------------------
>  1 files changed, 46 insertions(+), 73 deletions(-)

Your subject: needs to be fixed for all of these, as it does not
describe what part of the kernel is being modified.

A better example would be to use a prefix of:
	Subject: [PATCH XX/13] USB: skeleton: 
for all of these patches, so the shortlog entry is correct.

Care to redo this series, based on the feedback you've gotten, and
resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/