linux-kernel - Re: [PATCH 2/3] clk: add ICST307 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYvLEkuFLPCAT15jpqfML_tDwXuR6kENZbwMDaWpunrxQ@mail.gmail.com>
Date:	Wed, 13 Jun 2012 10:38:26 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Mike Turquette <mturquette@...com>
Cc:	linux-arm-kernel@...ts.infradead.org, arm@...nel.org,
	linux-kernel@...r.kernel.org, Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH 2/3] clk: add ICST307 driver

On Wed, Jun 13, 2012 at 1:06 AM, Mike Turquette <mturquette@...com> wrote:
> On 20120611-17:39, Linus Walleij wrote:

>> +obj-$(CONFIG_CLK_ICST)               += clk-icst.o
>
> Is there a better place to put this than the top-level directory?

I can put it alone in a subdirectory if you want to... It is used only
by the ARM reference designs AFAICT, shall I put these Integrator
things into clk/versatile as we use the "versatile" name to refer to all
ARM reference designs (i.e. arch/arm/plat-versatile).

>> +struct clk * __init icst_clk_init(struct device *dev, const struct clk_icst_desc *desc)
>
> Nitpick: icst_clk_init should be renamed icst_clk_register to more
> closely resemble other clock registration functions which allocate
> memory dynamically.

I'll fix!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/