linux-kernel - Re: [PATCH RFT 3/4] regulator: wm831x-dcdc: Convert wm831x_buckv_ops to set_voltage_sel and map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120613115058.GJ4545@opensource.wolfsonmicro.com>
Date:	Wed, 13 Jun 2012 12:50:58 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>
Subject: Re: [PATCH RFT 3/4] regulator: wm831x-dcdc: Convert wm831x_buckv_ops
 to set_voltage_sel and map_voltage

On Wed, Jun 13, 2012 at 07:41:26PM +0800, Axel Lin wrote:

> Or do you prefer I chenge the prototype to:

> static int wm831x_buckv_set_voltage_sel(struct regulator_dev *rdev,
>                                         unsigned vsel)

> Then the diff can be smaller.

Yes, this is the point.  A huge proportion of the change is a cosmetic
change for this rename which makes it much harder to read and review.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)