linux-kernel - Re: [PATCH] writeback: fix hung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120613011817.GA24315@localhost>
Date:	Wed, 13 Jun 2012 09:18:17 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Wanpeng Li <liwp.linux@...il.com>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Gavin Shan <shangw@...ux.vnet.ibm.com>
Subject: Re: [PATCH] writeback: fix hung_task alarm when sync block

> >> @@ -1311,7 +1312,12 @@ void writeback_inodes_sb_nr(struct super_block *sb,
> >>  
> >>  	WARN_ON(!rwsem_is_locked(&sb->s_umount));
> >>  	bdi_queue_work(sb->s_bdi, &work);
> >> -	wait_for_completion(&done);
> >> +	hangcheck = sysctl_hung_task_timeout_secs;
> >> +	if (hangcheck)
> >
> >The hangcheck variable looks redundant.
> 
> if sysctl_hung_task_timeout_secs is equal to ZERO, it means infinite
> timeout -- no checking done. So I think wait_for_completion_timeout 
> makes no sense this time.

I mean, you can test sysctl_hung_task_timeout_secs directly?
It's a one shot test anyway.

> >> +		while (!wait_for_completion_timeout(&done, HZ/2))
> >> +			;
> >> +	else
> >> +		wait_for_completion(&done);
> >>  }
> >>  EXPORT_SYMBOL(writeback_inodes_sb_nr);
> >>  
> >> -- 
> >> 1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/