linux-kernel - Re: linux-next: Tree for Jun 13 (crypto)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120613221458.21085iwxklwljhwc@www.81.fi>
Date:	Wed, 13 Jun 2012 22:14:58 +0300
From:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
To:	Johannes Goetzfried 
	<Johannes.Goetzfried@...ormatik.stud.uni-erlangen.de>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-crypto@...r.kernel.org, David Miller <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.hengli.com.au>
Subject: Re: linux-next: Tree for Jun 13 (crypto)

Quoting Johannes Goetzfried  
<Johannes.Goetzfried@...ormatik.stud.uni-erlangen.de>:

> On Wed, Jun 13, 2012 at 08:03:17PM +0300, Jussi Kivilinna wrote:
>> >arch/x86/crypto/serpent-avx-x86_64.o: In function `serpent_xts_decrypt':
>> >(.text+0x856c): multiple definition of `serpent_xts_decrypt'
>> >arch/x86/crypto/serpent-sse2-x86_64.o:(.text+0xae8): first defined here
>>
>> Reverting commit e2f4d85d5b2049a90859aa10de914ed31a4f17a4, "crypto:
>> serpent - add common glue code for avx and sse2 implementation",
>> should help for most.
>>
>> >arch/x86/crypto/serpent-avx-x86_64.o: In function `serpent_dec_blk_8way':
>> >(.text+0x3d70): multiple definition of `serpent_dec_blk_8way'
>> >arch/x86/crypto/serpent-avx-x86_64.o: In function `__serpent_enc_blk_8way':
>> >(.text+0x0): multiple definition of `__serpent_enc_blk_8way'
>>
>> Attached patch should solve these (patch depends on above revert).
>
> I'm really sorry about this, it shouldn't have happened. The most easiest
> solution to this problem would be to make the choice between
> CRYPTO_SERPENT_SSE2_X86_64 and CRYPTO_SERPENT_AVX_X86_64 an  
> exclusive-or choice
> in crypto/Kconfig. I don't think there is an use-case, where somebody would
> want to link both implementations into the same kernel image or even  
> load both
> implementations as module. This would avoid duplicating the glue-code again.

I'd think that most common use-case is distro-kernel, where all and  
everything is enabled by default.

>
> Another possibility would be to add a serpent-common-x86_64 module, but this
> wouldn't be a trivial change and imo a little bit too much just to avoid
> duplicating this code.

I'm working on patch-set that takes common glue code from  
serpent-sse2, serpent-avx, twofish-3way, twofish-avx and  
camellia-x86_64, to shared ablk_helper and glue_helper modules.

-Jussi



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/