linux-kernel - Re: [PATCH V3 2/3] i2c-nomadik: turn the platform driver to an amba driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Jun 2012 09:39:04 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Alessandro Rubini <rubini@...dd.com>
CC:	arnd@...db.de, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, giancarlo.asnaghi@...com,
	linux@....linux.org.uk, linus.walleij@...ricsson.com,
	srinidhi.kasagar@...ricsson.com, w.sang@...gutronix.de,
	khali@...ux-fr.org, linux-i2c@...r.kernel.org,
	STEricsson_nomadik_linux@...t.st.com, alan@...ux.intel.com
Subject: Re: [PATCH V3 2/3] i2c-nomadik: turn the platform driver to an amba
 driver

On 14/06/12 09:17, Alessandro Rubini wrote:
>> You change only one half of ux500 here: the part where the device
>> gets defined statically, but not not the definition in the
>> device-tree.
>
> Yes, I'm aware. That's why I added Lee Jones as Cc:, on Linusw's
> suggestion.  Lee told me to go ahead and he'll fix the DT stuff.

I did?

I have already DT:ed this driver. There are 3 patches on the MLs currently.

> [PATCH 1/3] i2c: Add Device Tree support to the Nomadik I2C driver
> [PATCH 2/3] ARM: ux500: Add i2c configurations to the Device Tree for DB8500 based devices
> [PATCH 3/3] Documentation: Device Tree binding information for i2c-nomadik driver

I'm more than happy for you to base your patches on these and make the 
necessary changes. Off hand, I think the only changes you'll need to 
make is the probing from DT itself.

So something like:

> --- a/arch/arm/boot/dts/db8500.dtsi
> +++ b/arch/arm/boot/dts/db8500.dtsi
> @@ -449,7 +449,7 @@
>                 };
>
>                 i2c@...04000 {
> -                       compatible = "stericsson,db8500-i2c", "st,nomadik-i2c";
> +                       compatible = "st,nomadik-i2c", "arm,primecell";
>                         reg = <0x80004000 0x1000>;
>                         interrupts = <0 21 0x4>;
>                         #address-cells = <1>;

... for each of the controllers.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/