| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Jun 2012 10:03:55 +0100 From: Ian Abbott <abbotti@....co.uk> To: H Hartley Sweeten <hartleys@...ionengravers.com> CC: Linux Kernel <linux-kernel@...r.kernel.org>, "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>, Ian Abbott <ian.abbott@....co.uk>, "fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org> Subject: Re: [PATCH 12/15] staging: comedi: 8255: refactor subdev_8255_insn function On 2012/06/13 11:42 PM, H Hartley Sweeten wrote: > Refactor the subdev_8255_insn function to follow what the user > space library is doing. > > 1) This function requires 'data' to contain 2 parameters. Add a > sanity check for this (insn->n != 2). Actually, the comedi core will have already checked that. > 4) The user space library only checks for a < 0 return to indicate > an error. It appears that the 'return 2' in this function is supposed > to indicate the number of data parameters used to perform the command. > Return the insn->n value for this, the open coded '2' looks wrong. As long as it still returns 2, I don't care how you do it! -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@....co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists