linux-kernel - Re: [PATCH -next] rtc-twl: pass IRQF_ONESHOT to request_threaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACVXFVNtOQdsoD-v4BkyFXLPge7vgM-x+XYgESj8ksrQj=YfEA@mail.gmail.com>
Date:	Thu, 14 Jun 2012 18:46:07 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Alessandro Zummo <a.zummo@...ertech.it>,
	Grant Likely <grant.likely@...retlab.ca>
Cc:	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	Ming Lei <ming.lei@...onical.com>
Subject: Re: [PATCH -next] rtc-twl: pass IRQF_ONESHOT to request_threaded_irq

On Thu, May 17, 2012 at 11:35 AM, Ming Lei <ming.lei@...onical.com> wrote:
> The flag of IRQF_ONESHOT should be passed to request_threaded_irq,
> otherwise the following failure message will be dumped because
> hardware handler is defined as NULL:
>
> [    3.329864] genirq: Threaded irq requested with handler=NULL and
> !ONESHOT for irq 363
> [    3.338226] twl_rtc twl_rtc: IRQ is not free.
> [    3.346099] twl_rtc: probe of twl_rtc failed with error -22
>
> The patch fixes the rtc-twl probe failure.
>
> Signed-off-by: Ming Lei <ming.lei@...onical.com>
> ---
>  drivers/rtc/rtc-twl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
> index 258abea..c5d06fe 100644
> --- a/drivers/rtc/rtc-twl.c
> +++ b/drivers/rtc/rtc-twl.c
> @@ -510,7 +510,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev)
>        }
>
>        ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
> -                                  IRQF_TRIGGER_RISING,
> +                                  IRQF_TRIGGER_RISING | IRQF_ONESHOT,
>                                   dev_name(&rtc->dev), rtc);
>        if (ret < 0) {
>                dev_err(&pdev->dev, "IRQ is not free.\n");

Ping...

Without the patch, rtc can't be used on Pandaboard.

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/