linux-kernel - Re: [PATCH] staging: zsmalloc: fix uninit'ed variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 14 Jun 2012 12:44:09 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Seth Jennings <sjenning@...ux.vnet.ibm.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Nitin Gupta <ngupta@...are.org>,
	Minchan Kim <minchan@...nel.org>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] staging: zsmalloc: fix uninit'ed variable warning

On Wed, Jun 13, 2012 at 04:03:42PM -0500, Seth Jennings wrote:
> This patch fixes an uninitialized variable warning in
> alloc_zspage().  It also fixes the secondary issue of
> prev_page leaving scope on each loop iteration.  The only
> reason this ever worked was because prev_page was occupying
> the same space on the stack on each iteration.
> 
> Signed-off-by: Seth Jennings <sjenning@...ux.vnet.ibm.com>

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> ---
>  drivers/staging/zsmalloc/zsmalloc-main.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/zsmalloc/zsmalloc-main.c b/drivers/staging/zsmalloc/zsmalloc-main.c
> index fb54a9b..4af3dd6 100644
> --- a/drivers/staging/zsmalloc/zsmalloc-main.c
> +++ b/drivers/staging/zsmalloc/zsmalloc-main.c
> @@ -400,7 +400,7 @@ static void init_zspage(struct page *first_page, struct size_class *class)
>  static struct page *alloc_zspage(struct size_class *class, gfp_t flags)
>  {
>  	int i, error;
> -	struct page *first_page = NULL;
> +	struct page *first_page = NULL, *uninitialized_var(prev_page);
>  
>  	/*
>  	 * Allocate individual pages and link them together as:
> @@ -415,7 +415,7 @@ static struct page *alloc_zspage(struct size_class *class, gfp_t flags)
>  	 */
>  	error = -ENOMEM;
>  	for (i = 0; i < class->pages_per_zspage; i++) {
> -		struct page *page, *prev_page;
> +		struct page *page;
>  
>  		page = alloc_page(flags);
>  		if (!page)
> -- 
> 1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/