linux-kernel - Re: [PATCH] init: add comments to keep initcall-names in sync with initcall levels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120614194721.GA32312@aftab.osrc.amd.com>
Date:	Thu, 14 Jun 2012 21:47:21 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Jim Cromie <jim.cromie@...il.com>, rusty@...tcorp.com.au,
	linux-kernel@...r.kernel.org, bp@...64.org, pawel.moll@....com,
	jbaron@...hat.com, gregkh@...uxfoundation.org
Subject: Re: [PATCH] init: add comments to keep initcall-names in sync with
 initcall levels

On Thu, Jun 14, 2012 at 09:23:03PM +0200, Paul Bolle wrote:
> On Thu, 2012-06-14 at 12:51 -0600, Jim Cromie wrote:
> > main.c has initcall_level_names[] for parse_args to print in debug messages,
> > add comments to keep them in sync with initcalls defined in init.h.
> > Also tweak comment re not using *_initcall macros in loadable modules.
> > 
> > Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> > ---
> >  include/linux/init.h |    3 ++-
> >  init/main.c          |    1 +
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/init.h b/include/linux/init.h
> > index 6b95109..da6f6f9 100644
> > --- a/include/linux/init.h
> > +++ b/include/linux/init.h
> > @@ -191,6 +191,7 @@ extern bool initcall_debug;
> >   * initializes variables that couldn't be statically initialized.
> >   *
> >   * This only exists for built-in code, not for modules.
> > + * Keep main.c:initcall_level_names[] in sync. */
> >   */
> 
> This comment now ends with "*/" twice. Perhaps that's legal

Of course it isn't, good catch Paul:

In file included from include/linux/printk.h:4:0,
                 from include/linux/kernel.h:22,
                 from include/asm-generic/bug.h:5,
                 from /usr/src/linux-2.6/arch/x86/include/asm/bug.h:38,
                 from include/linux/bug.h:4,
                 from include/linux/page-flags.h:9,
                 from kernel/bounds.c:9:
include/linux/init.h:195:3: error: expected identifier or ‘(’ before ‘/’ token
make[1]: *** [kernel/bounds.s] Error 1
make: *** [prepare0] Error 2

Jim, you need to test-build your patches no matter how trivial they are.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/