linux-kernel - Re: [PATCH] init: add comments to keep initcall-names in sync with initcall levels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1339708913.5981.16.camel@x61.thuisdomein>
Date:	Thu, 14 Jun 2012 23:21:53 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Jim Cromie <jim.cromie@...il.com>
Cc:	rusty@...tcorp.com.au, linux-kernel@...r.kernel.org, bp@...64.org,
	pawel.moll@....com, jbaron@...hat.com, gregkh@...uxfoundation.org
Subject: Re: [PATCH] init: add comments to keep initcall-names in sync with
 initcall levels

On Thu, 2012-06-14 at 14:32 -0600, Jim Cromie wrote:
> On Thu, Jun 14, 2012 at 1:23 PM, Paul Bolle <pebolle@...cali.nl> wrote:
> > On Thu, 2012-06-14 at 12:51 -0600, Jim Cromie wrote:
> >>
> >> -/* Don't use these in modules, but some people do... */
> >> +/* Don't use these in loadable modules, but some people do... */
> >
> > What problem does this solve?
> 
> kernel/params.c  and other builtins are also modules - at least wrt
> how theyre reported by dynamic_debug:
> 
> kernel/params.c:121 [params]parse_one =_ "Unknown argument `%s'\012"
> kernel/params.c:117 [params]parse_one =_ "Unknown argument: calling %p\012"
> kernel/params.c:108 [params]parse_one =_ "They are equal!  Calling %p\012"
> kernel/params.c:188 [params]parse_args =_ "Parsing ARGS: %s\012"
> 
> The advice to avoid those macros does not apply to builtin "modules"

I don't think I use dynamic_debug, but still, a pair of square brackets
doesn't make that some part of the kernel is considered to be a module,
does it? And more importantly, even if there's a difference between
"module" and "loadable module", which I rather doubt, aren't the people
who are expected to read this comment also expected to understand the
relevance of the preceding 
    #else /* MODULE */

line?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/