linux-kernel - Re: [PATCH v6 5/9] KVM: MMU: introduce SPTE_MMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FD94E39.50107@linux.vnet.ibm.com>
Date:	Thu, 14 Jun 2012 10:36:41 +0800
From:	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
To:	Marcelo Tosatti <mtosatti@...hat.com>
CC:	Avi Kivity <avi@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
	KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v6 5/9] KVM: MMU: introduce SPTE_MMU_WRITEABLE bit

On 06/14/2012 05:39 AM, Marcelo Tosatti wrote:


>> +	if (pt_protect)
>> +		spte &= ~SPTE_MMU_WRITEABLE;
>>  	spte = spte & ~PT_WRITABLE_MASK;
>> -	mmu_spte_update(sptep, spte);
>> +
>> +	*flush = mmu_spte_update(sptep, spte);
> 
> This clears previous flush value when looping over multiple sptes in 
> a single rmapp.
> 


In this case, mmu_spte_update alway return "true" since the spte is
always writable or can-be-writable-lockless.

I will cleanup it in the next version. Thank you, Marcelo!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/