linux-kernel - Re: [PATCH v4 0/3] scsi: fix internal write cache issue on usb hdd.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jun 2012 12:51:58 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	gregkh@...uxfoundation.org
Cc:	linux-usb@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	James.Bottomley@...senpartnership.com,
	mdharm-usb@...-eyed-alien.net, stern@...land.harvard.edu,
	sshtylyov@...sta.com, bvanassche@....org
Subject: Re: [PATCH v4 0/3] scsi: fix internal write cache issue on usb hdd.

Hi Greg.

Would you check this patch-set ?

Thanks.

2012/6/14, Namjae Jeon <linkinjeon@...il.com>:
> From: Namjae Jeon <namjae.jeon@...sung.com>
>
> The numbers of USB HDDs(All USB HDD I checked) does not respond
> correctly to scsi mode sense command for retrieving the write cache
> page status. Even though write cache is enabled by default, due to
> scsi driver assume that cache is not enabled which in turn might lead
> to loss of data since data still will be in cache.
> This result that all filesystems is not stable on USB HDD when the
> device is unplugged abruptly, even though these are having journaling
> feature. Our first trying is that scsi driver send ATA command
> (ATA Pass through, #58) to USB HDD after failure from normal routine to
> know write cache enable.
> We have known it is dangerous after testing several USB HDD. some of
> HDD is stalled by this command(A-DATA HDD). So we tried to make the
> patch James's suggestion(usb quirk) on version 2 that add product ID
> and verdor ID of USB HDD to USB quirk list after checking write cache.
> All filesystem will be stable on USB HDD registered in quirk list.
> And it will be updated continuously.
>
> 	scsi: set to WCE if usb cache quirk is present.
> 	usb: storage: add support for write cache quirk on usb hdd.
> 	usb: storage: update usb devices for write cache quirk in quirk.
>
>  drivers/scsi/sd.c          |    9 +++++++--
>  include/scsi/scsi_device.h |    1 +
>  drivers/usb/storage/scsiglue.c |    5 +++++
>  drivers/usb/storage/usb.c      |    5 ++++-
>  include/linux/usb_usual.h      |    4 +++-
>  drivers/usb/storage/unusual_devs.h |   24 ++++++++++++++++++++++++
>  Documentation/kernel-parameters.txt |    2 ++
>  7 files changed, 46 insertions(+), 4 deletions(-)
> --
> 1.7.9.5
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/