linux-kernel - Re: [PATCH] tools lib traceevent: Replace malloc_or_die to plain malloc in alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mx453qvn.fsf@sejong.aot.lge.com>
Date:	Fri, 15 Jun 2012 17:45:32 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] tools lib traceevent: Replace malloc_or_die to plain malloc in alloc_event()

Hi,

On Thu, 14 Jun 2012 23:30:57 -0400, Steven Rostedt wrote:
> On Mon, 2012-06-11 at 15:28 +0900, Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@....com>
>> 
>> Because the only caller of the alloc_event()
>> (pevent_parse_event) checks return value properly,
>> it can be changed to use plain malloc.
>> 
>> Cc: Frederic Weisbecker <fweisbec@...il.com>
>> Cc: Steven Rostedt <rostedt@...dmis.org>
>> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
>> ---
>>  tools/lib/traceevent/event-parse.c |    4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
>> index c471075e4974..a6b5bcdc5580 100644
>> --- a/tools/lib/traceevent/event-parse.c
>> +++ b/tools/lib/traceevent/event-parse.c
>> @@ -621,7 +621,9 @@ static struct event_format *alloc_event(void)
>>  {
>>  	struct event_format *event;
>>  
>> -	event = malloc_or_die(sizeof(*event));
>> +	event = malloc(sizeof(*event));
>> +	if (!event)
>> +		return NULL;
>>  	memset(event, 0, sizeof(*event));
>
> Perhaps we should combined these to:
>
> {
> 	struct event_format *event;
>
> 	event = calloc(1, sizeof(*event));
> 	return event;
> }
>
> Or even:
>
> {
> 	return calloc(1, sizeof(struct event_format));
> }
>

Ok, I'll take this. Thanks.
Namhyung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/