linux-kernel - Re: [PATCH v2] regulator: add new regulator driver for lp872x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120615114125.GC4482@opensource.wolfsonmicro.com>
Date:	Fri, 15 Jun 2012 12:41:25 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	"Kim, Milo" <Milo.Kim@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Girdwood, Liam" <lrg@...com>
Subject: Re: [PATCH v2] regulator: add new regulator driver for lp872x

On Fri, Jun 15, 2012 at 07:11:48PM +0800, Axel Lin wrote:

> > +       ret = gpio_request(gpio, "LP872X DVS");

> devm_gpio_request

Better yet...

> > +       gpio_direction_output(gpio, dvs->init_state);

...devm_gpio_request_one().

> > +module_i2c_driver(lp872x_driver);

> I think you need to use subsys_initcall() here.

> Regulators need to be available early in init in order to allow them
> to be available for consumers when requested.

Well, it depends on the regulator.  Those with DCDCs that might supply
cpufreq do because cpufreq can't use deferred probes.  Others should now
be able to use deferred probes which should removed the need for this.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)