linux-kernel - Re: [PATCH 08/14] mfd: Add IRQ domain support for the AB8500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FDB2F6A.8080300@linaro.org>
Date:	Fri, 15 Jun 2012 13:49:46 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	grant.likely@...retlab.ca, linus.walleij@...ricsson.com,
	arnd@...db.de, Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 08/14] mfd: Add IRQ domain support for the AB8500

On 14/06/12 19:32, Mark Brown wrote:
> On Mon, Jun 11, 2012 at 04:25:01PM +0100, Lee Jones wrote:
>
>> +	if (np) {
>> +		ab8500->domain = irq_domain_add_linear(
>> +			np, num_irqs,&ab8500_irq_ops, ab8500);
>> +	}
>> +	else {
>> +		ab8500->domain = irq_domain_add_legacy(
>> +			NULL, num_irqs, ab8500->irq_base,
>> +			0,&ab8500_irq_ops, ab8500);
>> +	}
>
> This is odd, why are you forcing non-DT systems to use a legacy mapping?
> The more usual approach is to use a legacy mapping if and only if a base
> for the legacy range has been provided, otherwise the system will
> needlessly fail to initialise the device...

Makes sense. I'll re-submit.

>> +	if (!(ab8500->irq_base || np)) {
>> +		dev_info(&pdev->dev, "couldn't find irq-base and not doing DT boot\n");
>
> ...like this.  See regmap_irq for an example.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/