linux-kernel - Re: [PATCH -stable] ntp: Correct TAI offset during leap second

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FDB866E.1040504@us.ibm.com>
Date:	Fri, 15 Jun 2012 12:01:02 -0700
From:	John Stultz <johnstul@...ibm.com>
To:	stable@...r.kernel.org
CC:	Richard Cochran <richardcochran@...il.com>,
	Dave Jones <davej@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -stable]  ntp: Correct TAI offset during leap second

On 06/15/2012 11:56 AM, John Stultz wrote:
> Hey Greg,
>     Forgot to cc stable on this one. Thanks to Dave Jones for noticing!
> -john

Gah. Thunderbird's preformat wrecked that one. Sorry.
Here it is again.
-john

------------------

From: Richard Cochran<richardcochran@...il.com>

commit dd48d708ff3e917f6d6b6c2b696c3f18c019feed upstream.

When repeating a UTC time value during a leap second (when the UTC
time should be 23:59:60), the TAI timescale should not stop. The kernel
NTP code increments the TAI offset one second too late. This patch fixes
the issue by incrementing the offset during the leap second itself.

Signed-off-by: Richard Cochran<richardcochran@...il.com>
Signed-off-by: John Stultz<john.stultz@...aro.org>
---
  kernel/time/ntp.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
index f03fd83..e8c8671 100644
--- a/kernel/time/ntp.c
+++ b/kernel/time/ntp.c
@@ -412,6 +412,7 @@ int second_overflow(unsigned long secs)
  		if (secs % 86400 == 0) {
  			leap = -1;
  			time_state = TIME_OOP;
+			time_tai++;
  			printk(KERN_NOTICE
  				"Clock: inserting leap second 23:59:60 UTC\n");
  		}
@@ -426,7 +427,6 @@ int second_overflow(unsigned long secs)
  		}
  		break;
  	case TIME_OOP:
-		time_tai++;
  		time_state = TIME_WAIT;
  		break;

-- 
1.7.9.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/