linux-kernel - Re: [PATCH] staging: comedi: fix Kconfig for COMEDI_PCMCIA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FDB8C25.4070502@xenotime.net>
Date:	Fri, 15 Jun 2012 12:25:25 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org, fmhess@...rs.sourceforge.net,
	abbotti@....co.uk, gregkh@...uxfoundation.org
Subject: Re: [PATCH] staging: comedi: fix Kconfig for COMEDI_PCMCIA_DRIVERS

On 06/15/2012 09:18 AM, H Hartley Sweeten wrote:

> The depends on PCCARD is redundant. All of the comedi PCMCIA
> drivers depend on PCMCIA which can only be enabled if PCCARD
> is enabled. Remove the extra depends check.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Ian Abbott <abbotti@....co.uk>
> Cc: Frank Mori Hess <fmhess@...rs.sourceforge.net>
> Cc: Greg Kroah-Hartman <gregkh@...uxfondation.org>


Reported-by: Randy Dunlap <rdunlap@...otime.net>
Acked-by: Randy Dunlap <rdunlap@...otime.net>

Thanks.

> ---
>  drivers/staging/comedi/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> index 848cf7e..2ca7f08 100644
> --- a/drivers/staging/comedi/Kconfig
> +++ b/drivers/staging/comedi/Kconfig
> @@ -1097,7 +1097,7 @@ endif # COMEDI_PCI_DRIVERS
>  
>  menuconfig COMEDI_PCMCIA_DRIVERS
>  	tristate "Comedi PCMCIA drivers"
> -	depends on (PCMCIA || PCCARD)
> +	depends on PCMCIA
>  	---help---
>  	  Enable comedi PCMCIA and PCCARD drivers to be built
>  



-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/