linux-kernel - Re: [PATCH tip/core/rcu 07/14] key: Remove extraneous parentheses from rcu_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120615205055.GK31184@leaf>
Date:	Fri, 15 Jun 2012 13:50:56 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, rostedt@...dmis.org, Valdis.Kletnieks@...edu,
	dhowells@...hat.com, eric.dumazet@...il.com, darren@...art.com,
	fweisbec@...il.com, patches@...aro.org
Subject: Re: [PATCH tip/core/rcu 07/14] key: Remove extraneous parentheses
 from rcu_assign_keypointer()

On Fri, Jun 15, 2012 at 01:13:08PM -0700, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> 
> This commit removes the extraneous parentheses from rcu_assign_keypointer()
> so that rcu_assign_pointer() can be wrapped in do-while.
> 
> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  include/linux/key.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/key.h b/include/linux/key.h
> index 4cd22ed..6fafcf4 100644
> --- a/include/linux/key.h
> +++ b/include/linux/key.h
> @@ -303,7 +303,7 @@ static inline bool key_is_instantiated(const struct key *key)
>  				   rwsem_is_locked(&((struct key *)(KEY))->sem)))
>  
>  #define rcu_assign_keypointer(KEY, PAYLOAD)				\
> -	(rcu_assign_pointer((KEY)->payload.rcudata, PAYLOAD))
> +	rcu_assign_pointer((KEY)->payload.rcudata, PAYLOAD)
>  
>  #ifdef CONFIG_SYSCTL
>  extern ctl_table key_sysctls[];
> -- 
> 1.7.8
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/