linux-kernel - Re: [PATCH tip/core/rcu 03/15] rcu: Prevent excessive line length in RCU_STATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120615214813.GU31184@leaf>
Date:	Fri, 15 Jun 2012 14:48:13 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, rostedt@...dmis.org, Valdis.Kletnieks@...edu,
	dhowells@...hat.com, eric.dumazet@...il.com, darren@...art.com,
	fweisbec@...il.com, patches@...aro.org,
	"Paul E. McKenney" <paul.mckenney@...aro.org>
Subject: Re: [PATCH tip/core/rcu 03/15] rcu: Prevent excessive line length in
 RCU_STATE_INITIALIZER()

On Fri, Jun 15, 2012 at 02:05:58PM -0700, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <paul.mckenney@...aro.org>
> 
> Upcoming rcu_barrier() concurrency commits will result in line lengths
> greater than 80 characters in the RCU_STATE_INITIALIZER(), so this commit
> shortens the name of the macro's argument to prevent this.
> 
> Signed-off-by: Paul E. McKenney <paul.mckenney@...aro.org>
> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  kernel/rcutree.c |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/kernel/rcutree.c b/kernel/rcutree.c
> index 9098910..8ce1b1d 100644
> --- a/kernel/rcutree.c
> +++ b/kernel/rcutree.c
> @@ -62,18 +62,18 @@
>  
>  static struct lock_class_key rcu_node_class[RCU_NUM_LVLS];
>  
> -#define RCU_STATE_INITIALIZER(structname) { \
> -	.level = { &structname##_state.node[0] }, \
> +#define RCU_STATE_INITIALIZER(sname) { \
> +	.level = { &sname##_state.node[0] }, \
>  	.fqs_state = RCU_GP_IDLE, \
>  	.gpnum = -300, \
>  	.completed = -300, \
> -	.onofflock = __RAW_SPIN_LOCK_UNLOCKED(&structname##_state.onofflock), \
> -	.orphan_nxttail = &structname##_state.orphan_nxtlist, \
> -	.orphan_donetail = &structname##_state.orphan_donelist, \
> -	.fqslock = __RAW_SPIN_LOCK_UNLOCKED(&structname##_state.fqslock), \
> +	.onofflock = __RAW_SPIN_LOCK_UNLOCKED(&sname##_state.onofflock), \
> +	.orphan_nxttail = &sname##_state.orphan_nxtlist, \
> +	.orphan_donetail = &sname##_state.orphan_donelist, \
> +	.fqslock = __RAW_SPIN_LOCK_UNLOCKED(&sname##_state.fqslock), \
>  	.n_force_qs = 0, \
>  	.n_force_qs_ngp = 0, \
> -	.name = #structname, \
> +	.name = #sname, \
>  }
>  
>  struct rcu_state rcu_sched_state = RCU_STATE_INITIALIZER(rcu_sched);
> -- 
> 1.7.8
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/