linux-kernel - Re: [PATCH] tracing: Fix the outmost stupidity of tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1339720321.13377.301.camel@gandalf.stny.rr.com>
Date:	Thu, 14 Jun 2012 20:32:01 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH] tracing: Fix the outmost stupidity of tracing_off()

On Fri, 2012-06-15 at 02:00 +0200, Thomas Gleixner wrote:

>  commit 499e547057f5bba5cd6f87ebe59b05d0c59da905
>  Author: Steven Rostedt <srostedt@...hat.com>
>  Date:   Wed Feb 22 15:50:28 2012 -0500
> 
> Did you actually read what I wrote above?
> 
> > > That's still not an excuse for utter stupidity, really. Just check the
> > > commit date vs. your discovery time.
> 
> Emphasis on discovery time.
> 

Commit date was the local version. The pull request was March 14. It was
a hodge podge of updates that I pulled together. This could have been
where I pulled a stale branch. In fact, the fact that commit date was
Feb, and my push was almost a month later, could be exactly because I
grabbed the wrong branch :-/

Then most of my development goes on separate git branches. Sometimes I
rebase on top of tip and continue development, and sometimes I just
continue development on the branch I'm at and rebase when its done. It
may be months before I'm reusing code that I pushed out if the code I'm
working with is unrelated.

If this is an issue, I can change my work flow to always update to the
latest. Lately, I've actually been doing that. But a lot of time I just
work on my separate pieces, as they don't always have to do with each
other.

Since that change was submitted, I've pulled in and tested other
developers code, and did the 'remove stop machine with breakpoints'.
That code has been under development for about a year. And when it was
finally done, I even waited a few releases before pushing, and then only
pushing bits and pieces at a time.

Basically, yeah, the change went in in March, but I admit, I haven't
been developing with the latest code. A lot of the code I've been
working on is a year old, and the branches have not been updated to the
latest. June 6th came and Arnaldo asked for a feature in ftrace, and I
checked out a new branch based on latest tip. This was the first time I
encountered the bug.

I also use ftrace and tracing_off() extensively for work. But as we are
still on the 3.2-rt kernel, that would also keep me from seeing this as
well.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/