linux-kernel - Re: [PATCH 04/10] fblog: implement fblog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120616233526.7f830890@pyramind.ukuu.org.uk>
Date:	Sat, 16 Jun 2012 23:35:26 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Herrmann <dh.herrmann@...glemail.com>
Cc:	linux-serial@...r.kernel.org,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 04/10] fblog: implement fblog_redraw()

On Sun, 17 Jun 2012 00:04:20 +0200
David Herrmann <dh.herrmann@...glemail.com> wrote:

> This mostly copies the functionality from drivers/video/console/bitblit.c
> so we can draw the console content on all available framebuffers.
> 
> All speed optimizations have been removed for simplicity. The original
> code depends heavily on CONFIG_VT so we cannot share the codebase here.

No. That means we've got two sets of code to maintain not one. Fix the
dependancy.

Pull the relevant subset of struct vc_data into another struct
Make struct vc_data be

struct vc_data {
	struct vc_whatever
	rest
}

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/