linux-kernel - Re: [PATCH] extcon: Fix wrong index in max8997_extcon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH9JG2WrhxNRCnHPnJPSEuiNjfJaWO5KOpXNGzvoxRF_Erfo3A@mail.gmail.com>
Date:	Sat, 16 Jun 2012 13:01:20 +0900
From:	Kyungmin Park <kyungmin.park@...sung.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Chanwoo Choi <cw00.choi@...sung.com>,
	Myungjoo Ham <myungjoo.ham@...sung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] extcon: Fix wrong index in max8997_extcon_cable[]

Nice catch!

Acked-by: Kyungmin Park <kyungmin.park@...sung.com>

On 6/16/12, Axel Lin <axel.lin@...il.com> wrote:
> Currently, the index of "Dock-desk" and "Dock-card" are the same.
> Thus the latter one overrides the first one.
> Then we have problem when calling extcon_find_cable_index() because
> edev->supported_cable[7] only matches "Dock-card".
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/extcon/extcon-max8997.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c
> b/drivers/extcon/extcon-max8997.c
> index 23416e4..5ecf176 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -116,8 +116,8 @@ const char *max8997_extcon_cable[] = {
>  	[5] = "Charge-downstream",
>  	[6] = "MHL",
>  	[7] = "Dock-desk",
> -	[7] = "Dock-card",
> -	[8] = "JIG",
> +	[8] = "Dock-card",
> +	[9] = "JIG",
>
>  	NULL,
>  };
> --
> 1.7.9.5
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/