linux-kernel - Re: [PATCH 1/8] /proc/net/ entries for bluetooth protocols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120617.092637.2171077367789127221.yamato@redhat.com>
Date:	Sun, 17 Jun 2012 09:26:37 +0900 (JST)
From:	Masatake YAMATO <yamato@...hat.com>
To:	andrei.emeltchenko.news@...il.com
Cc:	linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org
Subject: Re: [PATCH 1/8] /proc/net/ entries for bluetooth protocols

Hi,

Thank you for reviewing.
I have a question.

>> +		sk = sk_entry(v);
>> +		bt = bt_sk(sk);
>> +		seq_printf(seq, "%pK %-6d %-6u %-6u %-6u %-6lu",
>> +			   sk,
>> +			   atomic_read(&sk->sk_refcnt),
>> +			   sk_rmem_alloc_get(sk),
>> +			   sk_wmem_alloc_get(sk),
>> +			   sock_i_uid(sk),
>> +			   sock_i_ino(sk)
>> +			);
>> +		seq_puts(seq, batostr(&bt->src));
> 
> batostr looks OK now but this will be outdated soon by %pMR.

As far as reading Documentation/printk-formats.txt and 
pointer() in lib/vsprintf.c, %pMR is not defined.
I guess you mean %pM, don't you?

I've tried following code, and it works as expected.

		baswap(&src_baswapped, &bt->src);
		baswap(&dst_baswapped, &bt->dst);

		seq_printf(seq, "%pK %-6d %-6u %-6u %-6u %-6lu %pM %pM %-6lu",
			   sk,
			   atomic_read(&sk->sk_refcnt),
			   sk_rmem_alloc_get(sk),
			   sk_wmem_alloc_get(sk),
			   sock_i_uid(sk),
			   sock_i_ino(sk),
			   &src_baswapped,
			   &dst_baswapped,
			   bt->parent? sock_i_ino(bt->parent): 0LU);


Masatake YAMATO
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/