linux-kernel - Re: [PATCH 03/12] irqdomain: Support for static IRQ mapping and association.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120617221625.97ED63E05C0@localhost>
Date:	Sun, 17 Jun 2012 16:16:25 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	linux-kernel@...r.kernel.org, Milton Miller <miltonm@....com>,
	Paul Mundt <lethal@...ux-sh.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Rob Herring <rob.herring@...xeda.com>
Subject: Re: [PATCH 03/12] irqdomain: Support for static IRQ mapping and association.

On Sat, 16 Jun 2012 15:58:39 +1000, Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:
> On Fri, 2012-06-15 at 23:01 -0600, Grant Likely wrote:
> > From: Paul Mundt <lethal@...ux-sh.org>
> > 
> > This adds a new strict mapping API for supporting creation of linux IRQs
> > at existing positions within the domain. The new routines are as follows:
> > 
> > For dynamic allocation and insertion to specified ranges:
> > 
> > 	- irq_create_identity_mapping()
> > 	- irq_create_strict_mappings()
> 
> How does that differ from NOMAP ? Any reason to add that rather than use
> NOMAP and some offset built into the PIC driver ?

Ultimately it simplifies the code.  It allows the irq controller to
specify arbitrary ranges of hwirq->irq mappings without any special
processing.  Some of the irq controllers have multiple hwirq ranges
that need to be mapped, and this is a reasonable approach for doing so
regardless of the revmap type.

Ideally I'd rather not do any of this and have the virqs dynamically
assigned, but as long as there are still platforms relying on static
platform_data it will be required.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/