[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1339927893-8842-3-git-send-email-stigge@antcom.de>
Date: Sun, 17 Jun 2012 12:11:33 +0200
From: Roland Stigge <stigge@...com.de>
To: cjb@...top.org, grant.likely@...retlab.ca, rob.herring@...xeda.com,
rmk+kernel@....linux.org.uk, ulf.hansson@...ricsson.com,
linus.walleij@...aro.org, linux-mmc@...r.kernel.org,
linux-kernel@...r.kernel.org, aletes.xgr@...il.com,
linux-arm-kernel@...ts.infradead.org
Cc: Roland Stigge <stigge@...com.de>
Subject: [PATCH v3 2/2] mmc: mmci.c: Remove wrong error handling of gpio 0
Zero is a valid GPIO and shouldn't be handled as an error return code from
of_get_named_gpio(). It was a leftover from old code before getting
pdata->gpio_*() was modified.
Signed-off-by: Roland Stigge <stigge@...com.de>
---
drivers/mmc/host/mmci.c | 5 -----
1 file changed, 5 deletions(-)
--- linux-2.6.orig/drivers/mmc/host/mmci.c
+++ linux-2.6/drivers/mmc/host/mmci.c
@@ -1216,12 +1216,7 @@ static void mmci_dt_populate_generic_pda
int bus_width = 0;
pdata->gpio_wp = of_get_named_gpio(np, "wp-gpios", 0);
- if (!pdata->gpio_wp)
- pdata->gpio_wp = -1;
-
pdata->gpio_cd = of_get_named_gpio(np, "cd-gpios", 0);
- if (!pdata->gpio_cd)
- pdata->gpio_cd = -1;
if (of_get_property(np, "cd-inverted", NULL))
pdata->cd_invert = true;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists