linux-kernel - Re: [PATCH] vga_switcheroo.h: fix pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Jun 2012 11:04:40 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH] vga_switcheroo.h: fix pci_dev warning

At Fri, 15 Jun 2012 12:46:17 -0700,
Randy Dunlap wrote:
> 
> From: Randy Dunlap <rdunlap@...otime.net>
> 
> Fix warnings on some architectures/configs (not on x86):
> 
> include/linux/vga_switcheroo.h:28:30: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
> include/linux/vga_switcheroo.h:28:30: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> 
> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
> Cc:	Takashi Iwai <tiwai@...e.de>

  Acked-by: Takashi Iwai <tiwai@...e.de>

And while we are at it, another trivial fix I stumbled on.


thanks,

Takashi

---
From: Takashi Iwai <tiwai@...e.de>
Subject: [PATCH] vga_switcheroo: Avoid double inclusion

Add a proper ifndef thingy to protect from the double inclusion.

Signed-off-by: Takashi Iwai <tiwai@...e.de>
---
 include/linux/vga_switcheroo.h |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/vga_switcheroo.h b/include/linux/vga_switcheroo.h
index 60da41f..539acd3 100644
--- a/include/linux/vga_switcheroo.h
+++ b/include/linux/vga_switcheroo.h
@@ -7,6 +7,9 @@
  * vga_switcheroo.h - Support for laptop with dual GPU using one set of outputs
  */
 
+#ifndef _LINUX_VGA_SWITCHEROO_H
+#define _LINUX_VGA_SWITCHEROO_H
+
 #include <linux/fb.h>
 
 enum vga_switcheroo_state {
@@ -71,3 +74,5 @@ static inline int vga_switcheroo_get_client_state(struct pci_dev *dev) { return
 
 
 #endif
+
+#endif /* _LINUX_VGA_SWITCHEROO_H */
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/