linux-kernel - Re: [PATCH] regulator: extend the fixed voltage regulator to accept voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120618094145.GC3974@opensource.wolfsonmicro.com>
Date:	Mon, 18 Jun 2012 10:41:45 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] regulator: extend the fixed voltage regulator to accept
 voltage

On Mon, Jun 18, 2012 at 10:19:42AM +0200, Guennadi Liakhovetski wrote:

> +#define FIXED_BASE "fixed-dummy"
> +#define FIXED_NAME FIXED_BASE "-00"
> +
>  struct fixed_regulator_data {
>  	struct fixed_voltage_config cfg;
>  	struct regulator_init_data init_data;
>  	struct platform_device pdev;
> +	char name[sizeof(FIXED_NAME)];

So, this looks pretty ugly and doesn't seem terribly directly related to
supplying a voltage parameter.  Please split it out into a separate
change.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)