linux-kernel - Re: [PATCH] regulator: extend the fixed voltage regulator to accept voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120618100657.GG3974@opensource.wolfsonmicro.com>
Date:	Mon, 18 Jun 2012 11:06:57 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] regulator: extend the fixed voltage regulator to accept
 voltage

On Mon, Jun 18, 2012 at 11:52:13AM +0200, Guennadi Liakhovetski wrote:

> Well, I never insist on being the most advanced aesthetics connaisseur, 
> but I think these two changes are related. The point is, that if we want 
> to support different voltages, boards will have several of these 
> regulators, therefore they'll need different names. We could splt this, 
> but just the first part - changing the name - would look kinda pointless 
> without the second one, don't you think?

The major point there is I shouldn't be reading the change and going
"hang on, this is talking about names not voltages but the changelog
only mentioned voltages, what's that about then?".  The code looked more
complex than I'd expect too.  I suspect we should be using kstrdup()...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)