linux-kernel - Re: [PATCH 2/4] Staging: xgifb: reorder the code a bit to be more module friendly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FDF085A.7030805@igalia.com>
Date:	Mon, 18 Jun 2012 12:52:10 +0200
From:	Miguel Gómez <magomez@...lia.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	arnaud.patard@...-net.org, aaro.koskinen@....fi,
	dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] Staging: xgifb: reorder the code a bit to be more
 module friendly

>>   /*****************************************************/
>>   /*                      MODULE                       */
>>   /*****************************************************/
>>
>> -MODULE_DESCRIPTION("Z7 Z9 Z9S Z11 framebuffer device driver");
>> -MODULE_LICENSE("GPL");
>> -MODULE_AUTHOR("XGITECH , Others");
>> -
>>   module_param(mode, charp, 0);
>> -module_param(vesa, int, 0);
>> -module_param(filter, int, 0);
>> -module_param(forcecrt2type, charp, 0);
>> +MODULE_PARM_DESC(mode,
>> +	"\nSelects the desired default display mode in the format XxYxDepth,\n"
>> +	"eg. 1024x768x16.\n");
>>
>> +module_param(forcecrt2type, charp, 0);
>>   MODULE_PARM_DESC(forcecrt2type,
>>   	"\nForce the second display output type. Possible values are NONE,\n"
>>   	"LCD, TV, VGA, SVIDEO or COMPOSITE.\n");
>
> What's with these "\n" in the string?  Shouldn't those be removed?

Sure, I'll clean them in the next round of patches :)

(sorry for the delay)

Cheers!

-- 
Miguel Gómez
Igalia - http://www.igalia.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/