linux-kernel - Re: [PATCH] regulator: extend the fixed voltage regulator to accept voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jun 2012 12:57:39 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] regulator: extend the fixed voltage regulator to accept
 voltage

On Mon, Jun 18, 2012 at 12:13:58PM +0200, Guennadi Liakhovetski wrote:
> On Mon, 18 Jun 2012, Mark Brown wrote:
> 
> > On Mon, Jun 18, 2012 at 11:52:13AM +0200, Guennadi Liakhovetski wrote:

> Ok, I can add an explanation, why the name changes are necessary.

Please do split it into a separate patch.

> > I suspect we should be using kstrdup()...

> I wouldn't. It would add one more kmalloc(), which is avoided with my 
> approach, then it would make a memcpy(), which we also don't need, because 
> we have to print the id into the string.

This is because you've decided to go and select a particular set of
names for the supplies rather than letting people configure them which
again isn't 100% obvious...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)