lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Jun 2012 17:19:18 +0400 From: Glauber Costa <glommer@...allels.com> To: Wanpeng Li <liwp.linux@...il.com> CC: Johannes Weiner <hannes@...xchg.org>, Michal Hocko <mhocko@...e.cz>, Balbir Singh <bsingharora@...il.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>, <cgroups@...r.kernel.org>, <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>, Gavin Shan <shangw@...ux.vnet.ibm.com> Subject: Re: [PATCH] mm/memcg: add unlikely to mercg->move_charge_at_immigrate On 06/18/2012 05:19 PM, Wanpeng Li wrote: > On Mon, Jun 18, 2012 at 05:09:36PM +0400, Glauber Costa wrote: >> On 06/18/2012 05:10 PM, Wanpeng Li wrote: >>> From: Wanpeng Li <liwp@...ux.vnet.ibm.com> >>> >>> move_charge_at_immigrate feature is disabled by default. Charges >>> are moved only when you move mm->owner and it also add additional >>> overhead. >> >> How big is this overhead? >> >> That's hardly a fast path. And if it happens to matter, it will be >> just bigger when you enable it, and the compiler start giving the >> wrong hints to the code. > > Thank you for your quick response. > > Oh, Maybe I should just write comments "move_charge_at_immigrate feature > is disabled by default. So add "unlikely", in order to compiler can optimize." > Again, do you have any reason to optimize that ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists