linux-kernel - Re: [PATCH][GIT PULL][v3.5] ftrace: Make all inline tags also include notrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Jun 2012 16:00:56 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Fengguang Wu <wfg@...ux.intel.com>
Subject: Re: [PATCH][GIT PULL][v3.5] ftrace: Make all inline tags also
 include notrace


* Steven Rostedt <rostedt@...dmis.org> wrote:

> On Mon, 2012-06-18 at 10:56 +0200, Ingo Molnar wrote:
> > * Steven Rostedt <rostedt@...dmis.org> wrote:
> > 
> > >     ftrace: Make all inline tags also include notrace
> > >     
> > >     Commit 5963e317b1 ftrace/x86: Do not change stacks in DEBUG when calling lockdep
> > >     prevented lockdep calls from the int3 breakpoint handler from reseting the
> > >     stack if a function that was called was in the process of being converted
> > >     for tracing and had a breakpoint on it.
> > 
> > That's now how we refer to commits ...
> > 
> > >     Commit 45959ee7 ftrace: Do not function trace inlined functions
> > >     only touched the 'inline' tags when CONFIG_OPMITIZE_INLINING was enabled.
> > 
> > neither this :-/
> > 
> > We tend to write it like this:
> > 
> >       Commit 45959ee7aa64 ("ftrace: Do not function trace 
> >       inlined functions") only touched the 'inline' tags when 
> >       CONFIG_OPMITIZE_INLINING was enabled.
> 
> This looks like something that should be added to SubmittingPatches.
> 
> Want me to rebase with a new changelog?

Yeah, please do - the changelogs were rather hard to read as it 
was not clear where a commit title ends and where the original 
sentence continues.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/