linux-kernel - Re: [RFC PATCH 0/2] libtraceevent/perf: Add support for trace-cmd plugins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340029292.25903.101.camel@gandalf.stny.rr.com>
Date:	Mon, 18 Jun 2012 10:21:32 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	David Ahern <dsahern@...il.com>, acme@...stprotocols.net,
	linux-kernel@...r.kernel.org, weisbec@...il.com,
	namhyung.kim@....com, mingo@...nel.org, peterz@...radead.org
Subject: Re: [RFC PATCH 0/2] libtraceevent/perf: Add support for trace-cmd
 plugins

On Mon, 2012-06-18 at 17:35 +0900, Namhyung Kim wrote:
> Hi, David
> 
> On Thu, 14 Jun 2012 11:35:31 -0600, David Ahern wrote:
> > Now that perf is using libtraceevent and libtraceevent is based
> > on trace-cmd both can be extended to leverage the plugins written
> > for trace-cmd to improve pretty printing of the events.
> >
> > Given that it is based on code from trace-cmd I am not sure what the
> > right approach is, so wanted to throw this out for comments/suggestions.
> >
> 
> Yeah, it can be useful to reuse existing code for extending the
> functionality. But I'm not so sure including the plugin APIs into
> libtraceevent is the right thing (at least in its current form).
> 
> And for this particular case in patch 2/2, it seems that format of the
> kvm_emulate_insn event is broken already and should be fixed anyway.
> Further improvement in this area can be addressed in perf kvm or other
> users if needed.
> 
> So I'd like to hear from others.
> Arnaldo and Steven, what do you think?

It's been crazy lately, so sorry for the late reply David.

Anyway, I think it is important to get this into either libtraceevent or
another library, but I agree with Namhyung that it should not go in, in
its current form.

Either we add the 'pevent_' names to it, and we need to change things a
bit.

I want to redesign the plugin interface. Well, I do not need to be the
one to redesign it, but it needs to be updated by someone.

Plugins need an interface that they can take parameters, or be modified
at run time. An option passed to perf or trace-cmd could modify how the
plugin works. Or during viewing of the output, parameters can be passed
to tell plugins to do things differently.

Basically, we need to discuss the interface between plugins and the
libtraceevent library. Once we get a good idea of what is needed, then
we can start reusing the code from trace-cmd to make a much better
interface for users.

Thanks!

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/