linux-kernel - Re: [PATCH 14/22 v4] Input: atmel_mxt_ts - don't re-read matrix after applying pdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGS+omB9kixY29f7awPDaRc-t9t0LJ+Lwz=gBzUoXro5f9jYXg@mail.gmail.com>
Date:	Mon, 18 Jun 2012 23:28:01 +0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	Nick Dyer <nick.dyer@...ev.co.uk>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Henrik Rydberg <rydberg@...omail.se>,
	Joonyoung Shim <jy0922.shim@...sung.com>,
	linux-input@...r.kernel.org,
	Iiro Valkonen <iiro.valkonen@...el.com>,
	Benson Leung <bleung@...omium.org>,
	Yufeng Shen <miletus@...omium.org>,
	Olof Johansson <olofj@...omium.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/22 v4] Input: atmel_mxt_ts - don't re-read matrix after
 applying pdata

On Mon, Jun 18, 2012 at 11:03 PM, Nick Dyer <nick.dyer@...ev.co.uk> wrote:
>
> Daniel Kurtz wrote:
> > The matrix x/y size in the Info ID Block represents the number of x/y
> > trace lines on the device.  There is no need to re-read them after
> > applying pdata config, since pdata only configures the object table
> > etnries.  The matrix size read from the ID can only be updated by a
> > firmware update.
>
> This isn't correct. For example, mXT224 can be configured as 16x14, 17x13,
> 18x12, etc. This only takes effect when the chip is reset, which is why it
> is necessary to re-read them after applying the config.

Ah, so is that what T46.1 (Mode) does?  I hadn't played with that yet.
Ok, I'll move this patch into the next series which cleans up all of
the configuration stuff.

-Dan

>
>
> cheers
>
> --
> Nick Dyer
> Software Engineer, ITDev Ltd
> Hardware and Software Development Consultancy
> Website: http://www.itdev.co.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/