linux-kernel - Re: [PATCH 3/3] usb: gadget: mass_storage: require backing file for non-removable LUNs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.wf3ur7dppw9a85@mpn-glaptop>
Date:	Mon, 18 Jun 2012 17:32:21 +0200
From:	"Michal Nazarewicz" <mpn@...gle.com>
To:	"Alan Stern" <stern@...land.harvard.edu>
Cc:	"Felipe Balbi" <balbi@...com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] usb: gadget: mass_storage: require backing file for
 non-removable LUNs

On Mon, 18 Jun 2012 16:18:41 +0200, Alan Stern <stern@...land.harvard.edu> wrote:

> On Mon, 18 Jun 2012, Michal Nazarewicz wrote:
>
>> From: Michal Nazarewicz <mina86@...a86.com>
>>
>> The fsg_file_store() function does not check whether a LUN is removable or not
>> allowing one to specify an empty file name for a non-removable LUN.  This
>> commit adds explicit check of whether a file name is provided for
>> non-removable LUNs.
>
> Looks okay.  Note that in file_storage.c, the "file" attribute isn't
> writable if the LUN isn't removable, and the "ro" attribute isn't
> writable if the LUN is a cdrom.  Maybe you would prefer to do things
> that way instead.

Makes sense, I'll rewrite this patch to do that.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/