linux-kernel - Re: [PATCH 1/2 v2] regulator: support multiple dummy fixed regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120618162058.GT3974@opensource.wolfsonmicro.com>
Date:	Mon, 18 Jun 2012 17:20:58 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>
Subject: Re: [PATCH 1/2 v2] regulator: support multiple dummy fixed regulators

On Mon, Jun 18, 2012 at 05:57:24PM +0200, Guennadi Liakhovetski wrote:
> Currently regulator_register_fixed() uses a constant name to register a
> fixed dummy regulator. This is sufficient in principle, since there is no
> reason to register multiple such regulators. The user can simply supply all
> consumers in one array and use it to initialise such a regulator. However,
> in some cases it can be convenient to register multiple such regulators.
> This is also easy to achieve by appending the device ID to the name. It is

None of this seems terribly obvious to me.  Once we're getting into
allowing the user to specify a voltage (and possibly other parameters)
for the regulator it's hopefully going to refer to an actual thing we
can point at on the board rather than a virtual thing we've got to
satisfy software so giving it a useful name seems more useful (like a
name correspoding to the relevant supply on the schematic).  

There's also the fact that there shouldn't be any need for unique
regulator names internally so if it really doesn't matter we should be
able to give everything the same name happily enough.

> also consistent with the current behaviour of the code, that fixes a name
> itself without giving the user a possibility to provide a custom one.

This is done on the basis that it's an entirely virtual regulator which
doesn't have any meaningful mapping into the hardware.  If it's got a
voltage then that's no longer true.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)