linux-kernel - Re: [PATCH -stable] ntp: Correct TAI offset during leap second

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120618162854.GA3111@netboy.at.omicron.at>
Date:	Mon, 18 Jun 2012 18:28:55 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	Jonathan Nieder <jrnieder@...il.com>,
	John Stultz <johnstul@...ibm.com>, stable@...r.kernel.org,
	Sasha Levin <levinsasha928@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Dave Jones <davej@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -stable]  ntp: Correct TAI offset during leap second

On Mon, Jun 18, 2012 at 02:55:11PM +0100, Ben Hutchings wrote:
> On Sun, 2012-06-17 at 19:34 +0200, Richard Cochran wrote:
> > The offset should change upon entering state OOP, so something like
> > the following (untested) patch should fix it for 3.2.9.
> [...]
> 
> It looks like this patch just changes the offset reported by adjtimex()
> during an inserted second; is that right?

Right, nothing really terrible will happen. The worst that I can
imagine is that ntpd will set the new TAI offset during OOP, and then
the kernel will add one to it, resulting in the TAI offset being off
by one.

But I really doubt any software makes use of this information.

> Other than that, is 3.2.y likely to be OK?  Is there a good way to test
> that in advance; does
> <http://codemonkey.org.uk/2012/06/15/testing-leap-code/> look
> reasonable?

Well, if you want to wait all night then that is one way to do it.
Here is a little test program I have been using:

   https://github.com/richardcochran/leap

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/