linux-kernel - Re: [PATCH 1/2] pinctrl/pinctrl-tegra: remove IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FDF6DDE.3020306@wwwdotorg.org>
Date:	Mon, 18 Jun 2012 12:05:18 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Devendra Naga <devendra.aaru@...il.com>
CC:	Linus Walleij <linus.walleij@...aro.org>,
	Stephen Warren <swarren@...dia.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] pinctrl/pinctrl-tegra: remove IS_ERR checking of
 pmx->pctl

On 06/18/2012 11:44 AM, Devendra Naga wrote:
> pinctrl_register returns a pointer of struct type struct pinctrl_dev,
> if successfully registered to pinctrl subsystem, otherwise returns
> NULL, and there wont' be any pointers which are not dereferencible.
> 
> They are not type of pointer addresses but are kind of error
> codes rather actual addresses, but are a kind of return
> codes of functions returning integer types.
> 
> return -ENODEV if device registration fails.
> 
> Signed-off-by: Devendra Naga <devendra.aaru@...il.com>

Oops.

Acked-by: Stephen Warren <swarren@...dotorg.org>

Probably Cc stable since this is wrong back as far as 3.4.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/