linux-kernel - Re: [PATCH 08/14] mfd: Add IRQ domain support for the AB8500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120618185638.GY3974@opensource.wolfsonmicro.com>
Date:	Mon, 18 Jun 2012 19:56:38 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Lee Jones <lee.jones@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>, arnd@...db.de,
	linux-kernel@...r.kernel.org, grant.likely@...retlab.ca,
	linux-arm-kernel@...ts.infradead.org, linus.walleij@...ricsson.com
Subject: Re: [PATCH 08/14] mfd: Add IRQ domain support for the AB8500

On Mon, Jun 18, 2012 at 11:20:03AM +0100, Russell King - ARM Linux wrote:

> > +	int offset = data->irq;

> Are you sure this is right?  I thought irq_data->irq was the Linux IRQ
> number, irq_data->hwirq was the interrupt number inside the domain.

Yes, that's correct.  I'm surprised the code runs without crashing...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)