linux-kernel - Re: [PATCH -mm 3/6] Fix the x86-64 page colouring code to take pgoff into account and use that code as the basis for a generic page colouring code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FDFA59D.5020200@redhat.com>
Date:	Mon, 18 Jun 2012 18:03:09 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Borislav Petkov <bp@...en8.de>, Andi Kleen <andi@...stfloor.org>,
	linux-mm@...ck.org, akpm@...ux-foundation.org, aarcange@...hat.com,
	peterz@...radead.org, minchan@...il.com, kosaki.motohiro@...il.com,
	hnaz@...xchg.org, mel@....ul.ie, linux-kernel@...r.kernel.org,
	Rik van Riel <riel@...riel.com>
Subject: Re: [PATCH -mm 3/6] Fix the x86-64 page colouring code to take pgoff
 into account and use that code as the basis for a generic page colouring
 code.

On 06/18/2012 04:37 PM, Borislav Petkov wrote:

> and your patch has some new ifs in it:
>
> @@ -386,12 +398,16 @@ void validate_mm(struct mm_struct *mm)
>   	int bug = 0;
>   	int i = 0;
>   	struct vm_area_struct *tmp = mm->mmap;
> +	unsigned long highest_address = 0;
>   	while (tmp) {
>   		if (tmp->free_gap != max_free_space(&tmp->vm_rb))
>   			printk("free space %lx, correct %lx\n", tmp->free_gap, max_free_space(&tmp->vm_rb)), bug = 1;
>
> 			^^^^^^^^^^^^^^
>
> I think this if-statement is the problem. It is not present in mainline
> but this patch doesn't add it so some patch earlier than that adds it
> which is probably in your queue?

Argh! I see the problem now.

guilt-patchbomb sent everything from my second patch onwards,
not my first patch :(

Let me resend the series properly, I have 7 patches not 6.

I am having a bad email day...

-- 
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/