linux-kernel - Re: [PATCH 2/2] pinctrl: pinctrl-mxs: fix implicit declaration of free()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZzj2J8UY30Ee+XEtf2NarJJzVzzHCWkucptUuQb3L_ww@mail.gmail.com>
Date:	Mon, 18 Jun 2012 08:04:46 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Otavio Salvador <otavio@...ystems.com.br>,
	Devendra aaru <devendra.aaru@...il.com>,
	Fabio Estevam <festevam@...il.com>, fabio.estevam@...escale.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: pinctrl-mxs: fix implicit declaration of free()

On Sun, Jun 17, 2012 at 5:17 PM, Otavio Salvador
<otavio@...ystems.com.br> wrote:

> ,--[ build failure ]
> | ...
> | .../pinctrl-mxs.c: In function 'mxs_dt_node_to_map':
> | .../pinctrl-mxs.c:140:3: error: implicit declaration of function 'free'
> |                   [-Werror=implicit-function-declaration]
> | .../pinctrl-mxs.c:140:3: warning: incompatible implicit declaration of
> |                   built-in function 'free' [enabled by default]
> | ...
> `--
>
> Signed-off-by: Otavio Salvador <otavio@...ystems.com.br>
> Cc: Linus Walleij <linus.walleij@...aro.org>

Fabio Estevam already sent a patch to fix this, which is merged, thanks
anyway!

But:

>  free_group:
> -       if (!purecfg)
> -               free(group);
> +       kfree(group);

Why did you delete the if (!purecfg) clause?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/